Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MagiskManager constantly gets killed by OS (loses root, etc) #242

Closed
sou7611 opened this issue Jun 18, 2017 · 23 comments
Closed

MagiskManager constantly gets killed by OS (loses root, etc) #242

sou7611 opened this issue Jun 18, 2017 · 23 comments

Comments

@sou7611
Copy link

sou7611 commented Jun 18, 2017

Consistently, MagiskManager is getting killed by the OS

This results in no root access (since Manager provides SU), no MagiskHide, etc.

The only fix is to either reboot, or swipe-right the app in the recent apps list, and relaunch Manager, then all works correctly until the OS kills the manager app again. This can happen within minutes.

There is no logging as to what is going on, because when the OS kills the app (and root/SU is lost), there is no more logging (there is no access to the log file to write log entries).

This has progressively gotten worse as v13 development has progressed. It is not fixed with latest source.

@DeicPro
Copy link
Contributor

DeicPro commented Jun 18, 2017

yeah, but really you don't lost root.. is a gui stuff only..

@sou7611
Copy link
Author

sou7611 commented Jun 18, 2017

While it's true the device doesn't lose root, the fact that magisk manager handles MagiskSU tasks means you effectively lose access to root, because all su requests fail.

@DeicPro
Copy link
Contributor

DeicPro commented Jun 18, 2017

Yeah, it is a problem... BTW I would like the su database was a Magisk part and not Magisk Manager, to if I want all CLI not to have to ininstall the app and left /data/data/com.topjohnwu.magisk/databases/su.db file only.. So Magisk Manager to be 100% GUI and nothing more.

@sou7611
Copy link
Author

sou7611 commented Jun 18, 2017

That would seemingly solve the su issue.

@DeicPro
Copy link
Contributor

DeicPro commented Jun 18, 2017

Nope, it would the same, is only a suggestion apart of this issue, because the "BTW" (By The Way).

@sou7611
Copy link
Author

sou7611 commented Jun 18, 2017

Been trying Memory Locker to see if it helps prevent the app from being killed .... early results seem positive. This is the app that changes an application's priority level, so the OS memory manager would be less likely to kill the app when scavenging memory, vs normal.

@sou7611
Copy link
Author

sou7611 commented Jun 19, 2017

Memory Locker does not solve the issue, just delays it.

Magisk Manager is still (apparently) a high priority kill target for the OS.

When it's killed, ALL SU REQUESTES ARE DENIED, and everything stops working as a result ... anything using magiskhide, su, etc.

This needs to be a high priority fix.

@DeicPro
Copy link
Contributor

DeicPro commented Jun 19, 2017

The only stuff is related to the app is ask to allow su permissions... Saved su permissions, Magisk Hide, etc, are working correctly without the app.

@sou7611
Copy link
Author

sou7611 commented Jun 19, 2017 via email

@sou7611
Copy link
Author

sou7611 commented Jun 19, 2017

Also worth noting - when this happens SafetyNet starts failing as well (unknown if this is due to magiskhide failing, or some other cause).

@DeicPro
Copy link
Contributor

DeicPro commented Jun 20, 2017

Is not in your experience, is a fact. All works without Magisk Manager but new MagiskSU request. If you uninstall the app, but keep /data/data/com.topjohnwu.magisk/databases/su.db, you can use root in an app which you allowed request before.

Magisk Hide works, modules works, etc... Are related with Magisk daemon all those.

@sou7611
Copy link
Author

sou7611 commented Jun 20, 2017 via email

@DeicPro
Copy link
Contributor

DeicPro commented Jun 20, 2017

Rejected if was not allow before as I said... If is previously allowed, MagiskSU (Magisk daemon) read the database and give the root permissions.

@sou7611
Copy link
Author

sou7611 commented Jun 20, 2017 via email

@DeicPro
Copy link
Contributor

DeicPro commented Jun 20, 2017

screenshot_2017-06-20-22-23-30-435_jackpal androidterm

screenshot_2017-06-20-22-21-09-588_org adaway

@sou7611
Copy link
Author

sou7611 commented Jun 20, 2017 via email

@DeicPro
Copy link
Contributor

DeicPro commented Jun 20, 2017

screenshot_2017-06-20-22-51-46-918_com scottyab rootbeer sample
screenshot_2017-06-20-22-51-34-751_com scottyab safetynet sample

@sou7611
Copy link
Author

sou7611 commented Jun 20, 2017 via email

@DeicPro
Copy link
Contributor

DeicPro commented Jun 20, 2017

Yeah is an issue, but only affect to the popup of su request, not affect ALL as you says.

@sou7611
Copy link
Author

sou7611 commented Jun 20, 2017 via email

@DeicPro
Copy link
Contributor

DeicPro commented Jun 20, 2017

Your SafetyNet broken problem can't to be related with this, makes no sense.. is 100% binary stuff.

BTW, Interesting.. the Magisk Manager was killed by the system and showed me the popup request to ask... In previous releases It didn't show me nothing (except toast) and automatically rejected like you said.

@nullobsi
Copy link

I don't know about this, this is a heated debate. Have you tried disabling battery optimization for magisk manager in settings? although you said system task killer so that may not work... Sorry if I am repeating anything. 😃

@sou7611
Copy link
Author

sou7611 commented Jun 21, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants