Content in dt_fstab is not null terminated in emulator #2594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Value of <dt>/fstab/<partition>/dev and <dt>/fstab/<partition>/type in official Android emulator ends with newline instead of \0, Magisk won’t be able to patch sepolicy and crash the system. Signed-off-by: Shaka Huang <shakalaca@gmail.com>
topjohnwu
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Value of
<dt>/fstab/<partition>/devand<dt>/fstab/<partition>/typein official Android emulator ends with newline instead of \0, Magisk won’t be able to patch sepolicy and crash the system.With this change we should be able to able to install Magisk on emulator from API 17 to 29 (except 28 which is SAR) by patching the ramdisk.img
Signed-off-by: Shaka Huang shakalaca@gmail.com