Fix map growing #67
Merged
Fix map growing #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since controller-runtime does not provide a pod name if the pod is deleted, we can not delete an item storing event times from maps. To solve this, add a finalizer to pods to get their names. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
To make sure to delete a pod from job, set deletion policy to background for job deletion. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
Since check function runs peridically, it may miss a deleting pod event. To prevent it, run the function before deleting pod events from maps. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
The group name seems not to accept version. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
The previous code checks standard or dummy SC. But we actually want to check both. Signed-off-by: Toshikuni Fukaya <toshikuni-fukaya@cybozu.co.jp>
daichimukai
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We store pods event times to maps and delete them if pods are deleted. But we misunderstood the controller-runtime delete events that do not provide object names, the deletion did not work. This PR leverages a finalizer to get object names properly.