Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
.gitignore
templatesDetails
While working on my gitignore reader https://github.com/nielsbasjes/codeowners I ran into problems while using the templates that originated from here as a testing reference.
There are several places where the author of the template intended to create a comment but did not. The root cause is that in a
.gitignore
file a comment starts with a#
as the first character on a line. In all other places it is NOT interpreted as a comment.https://git-scm.com/docs/gitignore#_pattern_format states
I have verified this with the Dart.gitignore which has
If I create a
test.js
it is not ignored by git.I have checked all cases found by this:
Notes
This is 2 commits. One for the imported files from github and one for the files in this repo.
I have submitted these exact changes to github github/gitignore#4394 but it seems that repo has been unmanaged for over a year now.