Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude python mutation testing cache file #564

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

blablatdinov
Copy link

Pull Request

Thank you for contributing to @toptal/gitignore and https://www.gitignore.io.

New or update

Select the appropriate check box for this pull request. This helps when merging to ensure there are no conflicts with other templates or misunderstandings of how thee template list works.

New

  • Template - New .gitignore template
  • Composition - Template made from smaller templates
  • Inheritance - Template similar to an existing template
  • Patch - Template extending functionality of existing template

Update

  • Template - Update existing .gitignore template

Details

Add to python .gitignore template cache file from mutmut tool

@blablatdinov blablatdinov requested a review from a team as a code owner February 2, 2024 20:29
@blablatdinov blablatdinov changed the title Include python mutation testing cache file Exclude python mutation testing cache file Feb 2, 2024
@filipechagas filipechagas removed the request for review from a team February 5, 2024 18:25
@blablatdinov
Copy link
Author

@filipechagas

Take a look, please

@filipechagas
Copy link
Contributor

Thank you for contributing!

This file, however, is mirrored from https://github.com/github/gitignore/blob/main/Python.gitignore and will be overwritten by ci if we change it.
Additions to the upstream can be made using .patch files.

@blablatdinov
Copy link
Author

@filipechagas

Sorry, my bad. Move changes to templates/Python.patch file

@filipechagas filipechagas self-requested a review February 13, 2024 11:53
@filipechagas
Copy link
Contributor

Thank you for making the changes, @blablatdinov
This seems to be specific for projects using https://github.com/boxed/mutmut , though. So I'm not sure it should live in Python's gitignore. When that's the case, we usually create Files like this one https://github.com/toptal/gitignore/blob/master/templates/Android%2Breports.patch

In this case, Python+Mutmut seems more appropriate, wouldn't you agree?

@filipechagas filipechagas removed their request for review February 14, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants