feat: replace base Quill editor with Lexical #3586
Conversation
|
| @@ -0,0 +1,185 @@ | |||
| // import type { CSSProperties } from '@material-ui/core/styles/withStyles' | |||
| import { createStyles } from '@material-ui/core/styles' | |||
| // import { rem } from '@toptal/picasso-shared' | |||
There was a problem hiding this comment.
I decided to keep these styles, I think we will need them
| makeBoldFormat, | ||
| makeLinkFormat, | ||
| } from '../../formats' | ||
| import { makeHeaderFormat, makeBoldFormat, makeLinkFormat } from '../../formats' |
There was a problem hiding this comment.
we will remove this file, eventually
| @@ -1,7 +1,7 @@ | |||
| import React, { forwardRef, useRef } from 'react' | |||
| import type { BaseProps } from '@toptal/picasso-shared' | |||
|
|
|||
| import QuillEditorView from '../QuillEditorView' | |||
| import QuillEditorView from '../LexicalEditorView' | |||
There was a problem hiding this comment.
I would keep QuillEditor.tsx for a while
| position: 'relative', | ||
| // ...listStyles, | ||
| // ...margins, | ||
| // ...quillSpecificStyles(theme), |
There was a problem hiding this comment.
commented them, we will be needed
FX-4005
Description
We need to replace base functionality of RichTextEditor.
Quill Editor must be replaced by Lexical Editor.
We just need to implement basic functionality.
How to test
Development checks
PR commands
List of available commands:
@toptal-bot run package:alpha-release- Release alpha version@toptal-anvil ping reviewers- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?