Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [FX-4015] Integrate Rich Text Editor to Forms #3622

Merged
merged 4 commits into from
Jun 14, 2023
Merged

chore: [FX-4015] Integrate Rich Text Editor to Forms #3622

merged 4 commits into from
Jun 14, 2023

Conversation

dmaklygin
Copy link
Contributor

@dmaklygin dmaklygin commented Jun 13, 2023 •
edited
Loading

FX-4015

Description

We need to integrate a new RTE to Picasso Forms.

How to test

  • Check the regress on temploy

Screenshots

Picasso | Form 🔊 2023-06-13 13-09-49

Development checks

  • Make sure that additions and changes on design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
  • Annotate all props in component with documentation
  • Ensure that deployed demo has expected results and good examples
  • Self reviewed
  • Covered with tests

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@dmaklygin dmaklygin requested a review from a team June 13, 2023 11:10
@dmaklygin dmaklygin self-assigned this Jun 13, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5c0b97b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dmaklygin
Copy link
Contributor Author

@toptal-anvil ping reviewers

@toptal-devbot toptal-devbot temporarily deployed to temploy June 13, 2023 11:22 Inactive
@toptal-devbot toptal-devbot temporarily deployed to temploy June 13, 2023 15:50 Inactive
@dmaklygin
Copy link
Contributor Author

@toptal-anvil ping reviewers

sashuk
sashuk approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@sashuk sashuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on temploy; error and highlighted states work as expected!

@toptal-devbot toptal-devbot temporarily deployed to temploy June 13, 2023 16:04 Inactive
@dmaklygin dmaklygin merged commit bd250b2 into feature/rte-lexical Jun 14, 2023
@dmaklygin dmaklygin deleted the fx-4015-picasso-forms branch June 14, 2023 08:20
augustobmoura pushed a commit that referenced this pull request Jun 28, 2023
@dmaklygin
chore: [FX-4015] Integrate Rich Text Editor to Forms (#3622)
128e3d7 
* chore: integrate new rich text editor to forms

* chore: add highlight prop

* chore: enhance component

* chore: remove unnecessary tests cases
augustobmoura pushed a commit that referenced this pull request Jun 28, 2023
@dmaklygin
chore: [FX-4015] Integrate Rich Text Editor to Forms (#3622)
5f900ae 
* chore: integrate new rich text editor to forms

* chore: add highlight prop

* chore: enhance component

* chore: remove unnecessary tests cases
augustobmoura pushed a commit that referenced this pull request Jun 29, 2023
@dmaklygin
chore: [FX-4015] Integrate Rich Text Editor to Forms (#3622)
c65fa46 
* chore: integrate new rich text editor to forms

* chore: add highlight prop

* chore: enhance component

* chore: remove unnecessary tests cases
dmaklygin added a commit that referenced this pull request Jul 3, 2023
@dmaklygin
chore: [FX-4015] Integrate Rich Text Editor to Forms (#3622)
e940fd8 
* chore: integrate new rich text editor to forms

* chore: add highlight prop

* chore: enhance component

* chore: remove unnecessary tests cases
dmaklygin added a commit that referenced this pull request Jul 5, 2023
@dmaklygin
chore: [FX-4015] Integrate Rich Text Editor to Forms (#3622)
9d9d161 
* chore: integrate new rich text editor to forms

* chore: add highlight prop

* chore: enhance component

* chore: remove unnecessary tests cases
dmaklygin added a commit that referenced this pull request Jul 6, 2023
@dmaklygin
chore: [FX-4015] Integrate Rich Text Editor to Forms (#3622)
d15df1e 
* chore: integrate new rich text editor to forms

* chore: add highlight prop

* chore: enhance component

* chore: remove unnecessary tests cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashuk sashuk sashuk approved these changes

@augustobmoura augustobmoura augustobmoura approved these changes

@TomasSlama TomasSlama TomasSlama approved these changes

Assignees

@dmaklygin dmaklygin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dmaklygin @sashuk @augustobmoura @TomasSlama @toptal-devbot