Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TI-2599] Add placement prop to TypographyOverflow component #4357

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

ManarSayedEid
Copy link
Contributor

@ManarSayedEid ManarSayedEid commented Jun 11, 2024

TI-2599

Description

Add placement prop to TypographyOverflow component

How to test

Screenshots

image

Development checks

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@ManarSayedEid ManarSayedEid requested a review from a team June 11, 2024 12:59
Copy link

changeset-bot bot commented Jun 11, 2024

🦋 Changeset detected

Latest commit: e39b00e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@toptal/picasso-typography-overflow Patch
@toptal/picasso Patch
@toptal/picasso-file-input Patch
@toptal/picasso-step Patch
@toptal/picasso-tabs Patch
@toptal/picasso-forms Patch
@toptal/picasso-rich-text-editor Patch
@toptal/picasso-dropzone Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@toptal-devbot toptal-devbot added the contribution DO NOT ADD MANUALLY label Jun 11, 2024
@toptal-devbot
Copy link
Collaborator

Greetings from FX team, @ManarSayedEid 👋

Thank you so much for contributing 🙇

We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme!

What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉

🙏 please, help us improve, rate your contributing experience after merge

@ManarSayedEid
Copy link
Contributor Author

@toptal-anvil ping reviewers

Copy link
Contributor

@sashuk sashuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, the agreement from Design Team was received, tested on temploy, the only comment #4357 (comment)

@sashuk sashuk requested a review from a team June 12, 2024 15:40
@sashuk
Copy link
Contributor

sashuk commented Jun 12, 2024

@toptal-anvil ping reviewers

Copy link
Contributor

@TomasSlama TomasSlama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the contribution 🙇

@ManarSayedEid
Copy link
Contributor Author

@toptal-anvil ping reviewers

@Achillefs Achillefs merged commit b2f0d71 into master Jun 24, 2024
18 checks passed
@Achillefs Achillefs deleted the ti-2599 branch June 24, 2024 11:31
@toptal-build toptal-build mentioned this pull request Jun 24, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution DO NOT ADD MANUALLY Talent Insights Talent Insights team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants