Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-4585] Migrate NativeSelect to tailwind #4360

Merged
merged 13 commits into from
Jun 13, 2024

Conversation

augustobmoura
Copy link

@augustobmoura augustobmoura commented Jun 12, 2024

FX-4585

Description

Migrating MUI styles and components to tailwind and our own components

How to test

  • Temploy
  • Check temploy, Happo and code

Screenshots

No screenshots

Development checks

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@augustobmoura augustobmoura requested a review from a team June 12, 2024 04:06
Copy link

changeset-bot bot commented Jun 12, 2024

🦋 Changeset detected

Latest commit: 6a37c76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@toptal/picasso-select Major
@toptal/picasso-forms Patch
@toptal/picasso-query-builder Patch
@toptal/picasso-rich-text-editor Patch
@toptal/picasso Patch
@toptal/picasso-autocomplete Patch
@toptal/picasso-date-select Patch
@toptal/picasso-page Patch
@toptal/picasso-tagselector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@toptal-devbot
Copy link
Collaborator

toptal-devbot commented Jun 12, 2024

⚠️ Following packages are missing changesets. Please check if they don't require one.

@toptal/picasso-tag
@toptal/picasso-utils

@augustobmoura augustobmoura changed the base branch from master to feature/tailwind-w21 June 12, 2024 04:13
Copy link
Contributor

@TomasSlama TomasSlama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not forget to add the changeset, other than that I tested it manually in the storybook and everything looks fine 👍. I only left few small comments.

@TomasSlama TomasSlama requested a review from a team June 12, 2024 08:26
@AdrianContiu AdrianContiu self-requested a review June 12, 2024 14:05
Copy link
Contributor

@AdrianContiu AdrianContiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I have some question marks, please take a look and evaluate if they are suitable.

packages/base/Select/src/NativeSelect/NativeSelect.tsx Outdated Show resolved Hide resolved
packages/base/Select/package.json Show resolved Hide resolved
packages/base/Select/src/SelectCaret/SelectCaret.tsx Outdated Show resolved Hide resolved
@augustobmoura augustobmoura merged commit a33991d into feature/tailwind-w21 Jun 13, 2024
14 checks passed
@augustobmoura augustobmoura deleted the fx-4585-migrate-nativeselect branch June 13, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants