-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FX-5554] Remove picasso-tailwind dependency on picasso-tailwind-merge #4377
Conversation
🦋 Changeset detectedLatest commit: c2b204d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@toptal-bot run package:alpha-release |
Your alpha package is ready 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on consumer app side, works as expected
FX-5554
Description
Because picasso-tailwind is a pure CJS module, it caused a few problems with the expected webpack setup, which would try to transpile it to an ESM module. Besides, this dependency brought the whole
tailwind
package to the runtime bundle, which is unnecessary for such a simple case.I also added a unit test to guarantee that the 2 packages are in sync, while also adding a not to
picasso-tailwind
to remind developers that the two need to have the same valueHow to test
Screenshots
Development checks
props
in component with documentationexamples
for componentBreaking change
PR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?