Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TI-2735] Add DesignerPencil16, DesignerPencil24, productManager16 and productManager24 icons #4432

Merged
merged 2 commits into from
Aug 1, 2024

Conversation

ManarSayedEid
Copy link
Contributor

@ManarSayedEid ManarSayedEid commented Jul 31, 2024

TI-2735

Description

Add DesignerPencil16, DesignerPencil24, productManager16 and productManager24 icons
Figma: https://www.figma.com/design/TqaGgbpjGSUDf7qq153Isq/Iconography?node-id=3126-3&t=y7w4QkGKRfhXrdiU-0

How to test

Screenshots

description image
product manager icons image
designer pencil icons image

Development checks

Breaking change

  • n/a codemod is created and showcased in the changeset
  • n/a test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@ManarSayedEid ManarSayedEid self-assigned this Jul 31, 2024
@ManarSayedEid ManarSayedEid requested a review from a team July 31, 2024 23:37
Copy link

changeset-bot bot commented Jul 31, 2024

🦋 Changeset detected

Latest commit: 194d34a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 54 packages
Name Type
@toptal/picasso-icons Minor
@toptal/picasso-forms Patch
@toptal/picasso-query-builder Patch
@toptal/picasso-rich-text-editor Patch
@toptal/picasso Patch
@toptal/picasso-accordion Patch
@toptal/picasso-account-select Patch
@toptal/picasso-alert Patch
@toptal/picasso-application-update-notification Patch
@toptal/picasso-avatar Patch
@toptal/picasso-avatar-upload Patch
@toptal/picasso-breadcrumbs Patch
@toptal/picasso-button Patch
@toptal/picasso-calendar Patch
@toptal/picasso-carousel Patch
@toptal/picasso-date-picker Patch
@toptal/picasso-drawer Patch
@toptal/picasso-dropzone Patch
@toptal/picasso-empty-state Patch
@toptal/picasso-file-input Patch
@toptal/picasso-form Patch
@toptal/picasso-grid Patch
@toptal/picasso-helpbox Patch
@toptal/picasso-input Patch
@toptal/picasso-input-adornment Patch
@toptal/picasso-list Patch
@toptal/picasso-logo Patch
@toptal/picasso-menu Patch
@toptal/picasso-modal Patch
@toptal/picasso-notification Patch
@toptal/picasso-number-input Patch
@toptal/picasso-outlined-input Patch
@toptal/picasso-page Patch
@toptal/picasso-password-input Patch
@toptal/picasso-rating Patch
@toptal/picasso-section Patch
@toptal/picasso-select Patch
@toptal/picasso-show-more Patch
@toptal/picasso-step Patch
@toptal/picasso-table Patch
@toptal/picasso-tabs Patch
@toptal/picasso-tag Patch
@toptal/picasso-timepicker Patch
@toptal/picasso-user-badge Patch
@toptal/picasso-pagination Patch
@toptal/picasso-prompt-modal Patch
@toptal/picasso-skeleton-loader Patch
@toptal/picasso-tree-view Patch
@toptal/picasso-autocomplete Patch
@toptal/picasso-checkbox Patch
@toptal/picasso-radio Patch
@toptal/picasso-switch Patch
@toptal/picasso-tagselector Patch
@toptal/picasso-date-select Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@toptal-devbot toptal-devbot added the contribution DO NOT ADD MANUALLY label Jul 31, 2024
@toptal-devbot
Copy link
Collaborator

Greetings from FX team, @ManarSayedEid 👋

Thank you so much for contributing 🙇

We have got high priority ticket generated on our Kanban board so we will do our best to make your experience supreme!

What's next? We will collaborate using this workflow. For you this practically means making sure DONE criteria is met and responding promptly to code review comments 😉

🙏 please, help us improve, rate your contributing experience after merge

@ManarSayedEid
Copy link
Contributor Author

@toptal-anvil ping reviewers

@mkrl mkrl self-assigned this Aug 1, 2024
Copy link
Contributor

@mkrl mkrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for your contribution.

.changeset/four-students-dress.md Outdated Show resolved Hide resolved
@mkrl mkrl requested a review from a team August 1, 2024 10:22
Co-authored-by: Mikhail Korolev <mikhail.korolev@toptal.com>
@ManarSayedEid ManarSayedEid enabled auto-merge (squash) August 1, 2024 10:42
@ManarSayedEid ManarSayedEid merged commit 941aaa8 into master Aug 1, 2024
18 of 22 checks passed
@ManarSayedEid ManarSayedEid deleted the ti-2722-add-icons branch August 1, 2024 10:58
@toptal-build toptal-build mentioned this pull request Aug 1, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution DO NOT ADD MANUALLY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants