chore(Link): add react router example #605
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denieler
reviewed
Aug 19, 2019
bytasv
reviewed
Aug 20, 2019
havenchyk
force-pushed
the
FX-213-add-typescript-in-stories
branch
5 times, most recently
from
7b17e5d
to
f449358
Compare
havenchyk
force-pushed
the
FX-213-add-link-router-example
branch
from
9283e79
to
8655b43
Compare
havenchyk
changed the base branch from
FX-213-add-typescript-in-stories
to
fx-move-to-v4
|
🎉 Last commit is successfully deployed 🎉 Demo is available on: Your davinci-bot 🚀 |
bytasv
reviewed
Aug 21, 2019
|
|
||
| type PicassoRouterLink = RouterLinkProps & ComponentProps<typeof PicassoLink> | ||
|
|
||
| const Link = (props: PicassoRouterLink) => { |
There was a problem hiding this comment.
If we didn't have this Link wrapper - would TS complain about the incorrect interface being used? I mean if we just used it inline:
<PicassoLink underline='always' as={RouterLink} to='/'>
Home
</PicassoLink >
There was a problem hiding this comment.
PicassoLink doesn't have to property, that's why we need a wrapper
There was a problem hiding this comment.
it looks really weird as a simple example
There was a problem hiding this comment.
how do you imagine this example to be simplified? @denieler
denieler
reviewed
Aug 21, 2019
build/Icon/Performance16.js
Outdated
| @@ -1,31 +0,0 @@ | |||
| "use strict"; | |||
There was a problem hiding this comment.
not needed probably in this PR :)
There was a problem hiding this comment.
oh, it's done by mistake, sorry
MilosMosovsky
force-pushed
the
fx-move-to-v4
branch
8 times, most recently
from
e5aa2ed
to
bebea62
Compare
havenchyk
force-pushed
the
FX-213-add-link-router-example
branch
from
8655b43
to
8b39bd8
Compare
|
closing for now, will be added later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FX-213
Description
Add an example of usage ReactRouter Link with picasso Link. Fixes #379
How to test
Review
propsin component with documentationexamplesfor component