-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Link): add react router example #605
Conversation
7b17e5d
to
f449358
Compare
9283e79
to
8655b43
Compare
🎉 Last commit is successfully deployed 🎉 Demo is available on: Your davinci-bot 🚀 |
|
||
type PicassoRouterLink = RouterLinkProps & ComponentProps<typeof PicassoLink> | ||
|
||
const Link = (props: PicassoRouterLink) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we didn't have this Link
wrapper - would TS complain about the incorrect interface being used? I mean if we just used it inline:
<PicassoLink underline='always' as={RouterLink} to='/'>
Home
</PicassoLink >
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PicassoLink
doesn't have to
property, that's why we need a wrapper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks really weird as a simple
example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do you imagine this example to be simplified? @denieler
build/Icon/Performance16.js
Outdated
@@ -1,31 +0,0 @@ | |||
"use strict"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed probably in this PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, it's done by mistake, sorry
e5aa2ed
to
bebea62
Compare
8655b43
to
8b39bd8
Compare
closing for now, will be added later |
FX-213
Description
Add an example of usage ReactRouter Link with picasso Link. Fixes #379
How to test
Review
props
in component with documentationexamples
for component