Undefined method reference...

[PhoenixPeca]

Hi,

I would just like to point out a reference to a method that does not (or no longer) exists..

laravel-geoip/src/GeoIP.php

Line 164 in d00e9b5

$log->addError($e);

Possible fix: Seldaek/monolog@d686f25

[imami]

This is because addError method no longer exists in Monolog v. 2.0.
Maybe some major upgrade in laravel-geoip is needed!

@Torann

[PhoenixPeca]

Correct me if I'm wrong, but as I can see, the only usage of monolog in this repo is found in these lines:

laravel-geoip/src/GeoIP.php

Lines 162 to 164 in dc3c4fc

	$log = new Logger('geoip');
	$log->pushHandler(new StreamHandler(storage_path('logs/geoip.log'), Logger::ERROR));
	$log->addError($e);

so, i dont think a major upgrade is needed.. I have made a PR already for this: #153

[imami]

@PhoenixPeca You're correct

[Torann]

Looks like addError() just needs to be changed to error().

I'm also 100% fine with dropping the logger from here. I never use it.

[Torann]

LOL I just saw that you made the changes and put up a PR @PhoenixPeca. I'll merge it now 👍

[Torann]

Hold up. This change is breaking. I'll make a comment on the PR for a fix to prevent this

[Torann]

Ok. I just looked, v1.x of Monolog also has the method error, so this will not break anything. Merging now :-)