-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VolumetricBatchNormalization #665
Conversation
I really like this PR, very clean and nicely done. Maybe an easier solution (that could work for both backends) would be to do the resizing of the input/output inside the C/Cuda functions ? |
@fmassa I think that's a good idea. The tensor:view() function is implemented in Lua but not in C. I think we can effectively do the same thing in |
The BatchNormalization modules now all extend nn.BatchNormalization and use the same THNN/THCUNN implementation.
Updated PR with @fmassa's suggestion. (Tests pass VolumetricMaxPooling is flaky) |
Add VolumetricBatchNormalization
Very cool, thanks @colesbury ! |
Hmmm, this breaks BatchNormalization in clnn :-( For example, this means that http://torch.ch/blog/2015/07/30/cifar.html will no longer run on clnn |
@hughperkins The previous commit (adding C/Cuda implementations of |
Yes. "we" can :-P However, it would be nice to get a little @hughperkins in any future pull request that strips out lua implementation, and replaces it with c implementation :-) |
Add VolumetricBatchNormalization
All of the BatchNormalization modules now extend
nn.BatchNormalization
and use the same THNN/THCUNN implementation.