Change ConfusionMatrix accumulator from Float to Long. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumith
added a commit
that referenced
this pull request
Aug 3, 2015
Change ConfusionMatrix accumulator from Float to Long.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be the worlds smallest PR :-)
self.mat is only ever used as an integer accumulator, and so we're wasting a lot of bits... The max number of samples per matrix element is 2^24 = 16777216, which is actually pretty small (I hit the limit in my particular application). In retrospect, self.mat should have always been a LongTensor.
I don't think there are any unintended consequences. But if someone could do a quick scan of the code to double check, that would be awesome.
Cheers,
Jonathan