gen.with_timeout: Don't log CancelledError after timeout #2681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdarnell
added a commit
to bdarnell/tornado
that referenced
this pull request
Jun 22, 2019
python/cpython#13528 broke us in two ways: asyncio.CancelledError is no longer an alias for concurrent.futures.CancelledError and it's now a BaseException. Fixes tornadoweb#2677 Closes tornadoweb#2681
|
I'm not sure whether we want to automatically "quiet" CancelledErrors or not. We explicitly pass CancelledError as a quiet_exception here: Line 254 in c50aed0 I think as an immediate fix it's better to do something like #2683 to restore the old behavior. Maybe in the longer term we want something like this to always silence CancelledError. |
|
On second thought (see discussion in #2683), I think this is what we want here. I'll merge this PR and then use that one to do a little more cleanup (removing the now-useless references to CancelledError in locks.py, re-enabling 3.8 CI) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I'm not very familiar with Tornado, but I'm investigating the failure on Python 3.8 (#2677).
From commit a237a99, it seems that CancelledError should also be ignored in
tornado.gen.with_timeout'serror_callback. Is that right?This fixed tests on Python 3.8.0b1 for me.