auth: Various updates #3294
Merged
auth: Various updates #3294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bdarnell
commented
Jul 8, 2023
bdarnell
commented
- Deprecate unused client_secret parameter
- Deprecate TwitterMixin
- Add a demo app for Google OAuth and update docs
- Update facebook scope in comments
- Update facebook and top-of-file example comments
OAuth2Mixin.authorize_redirect has never used this argument and similar methods in this module don't have it. Closes tornadoweb#1122
It's unclear to what extent this class still works given Twitter's recent API changes. Deprecate it since I don't intend to track future changes here.
Add some more detail to app registration docs. This was done mainly to verify that we don't need to introduce new parameters as requested in tornadoweb#2140 Closes tornadoweb#2140
The read_stream scope was replaced with user_posts; this change was made to demos/facebook/facebook.py in tornadoweb#1674 but the corresponding comment was not updated. The offline_access scope has also been removed but seems irrelvant to this comment. Fixes tornadoweb#1566
Matches a change made to the Google auth mixin in a previous commit. Fixes tornadoweb#756
bdarnell
force-pushed
the
auth-updates
branch
3 times, most recently
from
20dbe52
to
91a809a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.