autoreload: Various updates #3302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running a directory has some but not all of the behavior of running a module, including setting __spec__, so we must be careful not to break things by assuming that __spec__ means module mode. Fixes tornadoweb#2855
This will make it easier to add other options (for tornadoweb#2398)
A previous commit added support for using autoreload within programs that were started as directories; this commit supports them when run with the -m tornado.autoreload wrapper. This change may have side effects for file mode since we now use runpy.run_path instead of executing the file by hand (I don't think the run_path function existed when this code was originally written).
This flag terminates the autoreload loop after the first successful run. This makes it possible to cleanly shut down a process that is using "python -m tornado.autoreload" without printing a traceback. Fixes tornadoweb#2398
bdarnell
force-pushed
the
autoreload-updates
branch
from
13b884f
to
6755b82
Compare
bdarnell
force-pushed
the
autoreload-updates
branch
from
6755b82
to
5b4007b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--until-successflag (autoreload: Make reload watch for exit status 0 optional #2398)