Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The derep_fulllength command fails to remove the part of the header after the space #338

Closed
torognes opened this issue Oct 8, 2018 · 4 comments
Assignees
Labels

Comments

@torognes
Copy link
Owner

torognes commented Oct 8, 2018

The derep_fulllength command fails to remove the part of the header after the space.

The part of the header line from the first space should be ignored (unless the --notrunclabels option is in effect). This does not seem to apply to the derep_fulllength command, but it should.

@torognes torognes added the bug label Oct 8, 2018
@torognes torognes self-assigned this Oct 8, 2018
@frederic-mahe
Copy link
Collaborator

frederic-mahe commented Oct 8, 2018

vsearch \
    --derep_fulllength <(printf ">header metadata\nA\n") \
    --minseqlength 1 \
    --sizeout \
    --quiet \
    --output -

gives:

>header metadata;size=1
A

instead of:

>header;size=1
A

I've written about a hundred tests for the dereplication-rereplication functions, but I have to admit I did not test the header parsing.

@frederic-mahe
Copy link
Collaborator

I've added two new tests for that specific issue (frederic-mahe/vsearch-tests@620cd91).

@torognes
Copy link
Owner Author

torognes commented Oct 9, 2018

The bug was introduced in version 2.8.2, but is fixed in version 2.8.6 just released.

@frederic-mahe
Copy link
Collaborator

PASS: derep_fulllength: header stops at first space (issue 338)
PASS: derep_fulllength: notrunclabels includes full header (issue 338)

Perfect :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants