Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config graph_bound documentation inconsistent #22

Closed
saizai opened this issue Oct 8, 2020 · 4 comments
Closed

Config graph_bound documentation inconsistent #22

saizai opened this issue Oct 8, 2020 · 4 comments

Comments

@saizai
Copy link

saizai commented Oct 8, 2020

https://nyx.torproject.org/#configuration says graph_bound is default max_local and options are global_max, local_max, tight

So… which is it, max_local or local_max? And to double check: max_global or global_max?
@saizai saizai mentioned this issue Oct 8, 2020
Closed
ghost pushed a commit that referenced this issue Oct 11, 2020
@atagar
Documented graph_bound incorrect
c099fe3 
Oops, inverted the words. Caught thanks to saizai...

  #22
@atagar
Copy link
Collaborator

atagar commented Oct 11, 2020

Oops, thanks saizai. Good catch. Accidentally pushed a fix prior to realizing that this came with a pull request.

https://gitweb.torproject.org/nyx.git/commit/?id=c099fe3

@atagar atagar closed this as completed Oct 11, 2020
@saizai
Copy link
Author

saizai commented Oct 12, 2020

Is gitweb.torproject the canonical repository, not github? If so, the github readme should say so prominently, since it's definitely not the default assumption.

@atagar
Copy link
Collaborator

atagar commented Oct 12, 2020

Thanks Sai. Github is our canonical bug tracker, but the code mirrors our tor repository. This is generally moot for our contributors.

@saizai
Copy link
Author

saizai commented Oct 13, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix nixrc documentation for graph_bound local_max [#22] saizai/nyx
2 participants
@saizai @atagar