Remove censorship (naming model like "Model", if name != "Model"
fix)
#1298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved
ModelMeta
field_map
collecting block from under the conditionif name != "Model"
:Motivation and Context
Removes censorship. Whole app crashes if I name my model or meta-model like literally "Model".
Ex:
If you wanna know my opinion, better not to use
__new__
and as litte as possible magic methods, you can useinspect.getmembers_static
(link, python 3.11 only) in case of not calling__get__
and others.How Has This Been Tested?
Tested in just CTRL+S and run, and reverse. Fixes the issue.
After successful fixing my issue, ran pytest.
Errors (i think, non mine):
Checklist: