-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement for FastAPI lifespan support (#1371) #1397
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5798325204
💛 - Coveralls |
I feel that this PR is not much different from before the change. What about just adding the corresponding warning and updating the example and docs? |
waketzheng
force-pushed
the
support-fastapi-lifespan
branch
from
June 10, 2023 20:19
aa5d090
to
a08ec3f
Compare
Warning added, example and docs updated. |
waketzheng
force-pushed
the
support-fastapi-lifespan
branch
from
August 8, 2023 16:00
63b2a2c
to
fce4edf
Compare
@long2ice take a look at this, |
waketzheng
force-pushed
the
support-fastapi-lifespan
branch
8 times, most recently
from
September 29, 2023 14:12
160c2a5
to
81e899e
Compare
waketzheng
force-pushed
the
support-fastapi-lifespan
branch
from
October 20, 2023 12:51
81e899e
to
fcc10a6
Compare
waketzheng
force-pushed
the
support-fastapi-lifespan
branch
from
November 18, 2023 13:39
fcc10a6
to
81e899e
Compare
@long2ice How to fix this unittest error:
|
waketzheng
force-pushed
the
support-fastapi-lifespan
branch
from
November 19, 2023 05:42
81e899e
to
fa0978f
Compare
ci failed, but my local test success. Move it to #1541 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separate
register_tortoise
toRegisterTortoise.init
andRegisterTortoise.close
functionMotivation and Context
Support fastapi's lifespan and compare old register format
How Has This Been Tested?
Checklist:
I have added tests to cover my changes.