Skip to content

Commit 7b78983

Browse files
miniplidavem330
authored andcommitted
xfrm_user: fix info leak in copy_to_user_policy()
The memory reserved to dump the xfrm policy includes multiple padding bytes added by the compiler for alignment (padding bytes in struct xfrm_selector and struct xfrm_userpolicy_info). Add an explicit memset(0) before filling the buffer to avoid the heap info leak. Signed-off-by: Mathias Krause <minipli@googlemail.com> Acked-by: Steffen Klassert <steffen.klassert@secunet.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent f778a63 commit 7b78983

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

Diff for: net/xfrm/xfrm_user.c

+1
Original file line numberDiff line numberDiff line change
@@ -1320,6 +1320,7 @@ static void copy_from_user_policy(struct xfrm_policy *xp, struct xfrm_userpolicy
13201320

13211321
static void copy_to_user_policy(struct xfrm_policy *xp, struct xfrm_userpolicy_info *p, int dir)
13221322
{
1323+
memset(p, 0, sizeof(*p));
13231324
memcpy(&p->sel, &xp->selector, sizeof(p->sel));
13241325
memcpy(&p->lft, &xp->lft, sizeof(p->lft));
13251326
memcpy(&p->curlft, &xp->curlft, sizeof(p->curlft));

0 commit comments

Comments
 (0)