Browse files

xfrm_user: fix info leak in copy_to_user_policy()

The memory reserved to dump the xfrm policy includes multiple padding
bytes added by the compiler for alignment (padding bytes in struct
xfrm_selector and struct xfrm_userpolicy_info). Add an explicit
memset(0) before filling the buffer to avoid the heap info leak.

Signed-off-by: Mathias Krause <>
Acked-by: Steffen Klassert <>
Signed-off-by: David S. Miller <>
  • Loading branch information...
1 parent f778a63 commit 7b789836f434c87168eab067cfbed1ec4783dffd @minipli minipli committed with davem330 Sep 19, 2012
Showing with 1 addition and 0 deletions.
  1. +1 −0 net/xfrm/xfrm_user.c
@@ -1320,6 +1320,7 @@ static void copy_from_user_policy(struct xfrm_policy *xp, struct xfrm_userpolicy
static void copy_to_user_policy(struct xfrm_policy *xp, struct xfrm_userpolicy_info *p, int dir)
+ memset(p, 0, sizeof(*p));
memcpy(&p->sel, &xp->selector, sizeof(p->sel));
memcpy(&p->lft, &xp->lft, sizeof(p->lft));
memcpy(&p->curlft, &xp->curlft, sizeof(p->curlft));

0 comments on commit 7b78983

Please sign in to comment.