Skip to content

Commit 8cae8cd

Browse files
Eric Sandeentorvalds
authored andcommitted
seq_file: disallow extremely large seq buffer allocations
There is no reasonable need for a buffer larger than this, and it avoids int overflow pitfalls. Fixes: 058504e ("fs/seq_file: fallback to vmalloc allocation") Suggested-by: Al Viro <viro@zeniv.linux.org.uk> Reported-by: Qualys Security Advisory <qsa@qualys.com> Signed-off-by: Eric Sandeen <sandeen@redhat.com> Cc: stable@kernel.org Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
1 parent 2734d6c commit 8cae8cd

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

fs/seq_file.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,9 @@ static void seq_set_overflow(struct seq_file *m)
3232

3333
static void *seq_buf_alloc(unsigned long size)
3434
{
35+
if (unlikely(size > MAX_RW_COUNT))
36+
return NULL;
37+
3538
return kvmalloc(size, GFP_KERNEL_ACCOUNT);
3639
}
3740

0 commit comments

Comments
 (0)