Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace event-based overlay management with useSyncExternalStore. #33

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

jungpaeng
Copy link
Member

@jungpaeng jungpaeng commented Jul 3, 2024

Although I didn’t achieve the original goal, the code has become cleaner, so I’ll keep it as it is.

close: #19
close: #31

@jungpaeng jungpaeng self-assigned this Jul 3, 2024
Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
overlay-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 3:41pm

@jungpaeng jungpaeng force-pushed the feat/overlay-use-sync-external-store branch from f383f48 to cd336ef Compare July 3, 2024 15:41
@jungpaeng jungpaeng merged commit 03c03a5 into main Jul 4, 2024
2 checks passed
@jungpaeng jungpaeng deleted the feat/overlay-use-sync-external-store branch July 4, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify to manage state outside of React [Question] Could we access open state from outside?
1 participant