-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-query): correct return type of useSuspendedQuery #73
Conversation
✅ Deploy Preview for slash-libraries ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I really want to add tsd's code for testing these types by myself👌~ if I can I want to check your meaning
|
@manudeli And yes, you can open an issue, and you can setup up tsd tests in whole monorepo. |
Ok, I will make an issue for plan to setup tsd on @toss/react-query first. |
Overview
Related Issue #72
I corrected useSuspendedQuery return type when enabled options in useSuspendedQuery is boolean
When enabled in options of useSuspendedQuery is boolean, data outside of if(isSuccess) statement can be undefined
But, data inside of if(isSuccess) statement have to be TData, not TData | undefined
when
enabled: boolean
, I thoughtSuspendedUseQueryResultOnSuccess | SuspendedUseQueryResultOnIdle
is right return type , notBaseSuspendedUseQueryResult
Incorrect:
BaseSuspendedUseQueryResult<TData | undefined>
Expected:
SuspendedUseQueryResultOnSuccess<TData> | SuspendedUseQueryResultOnIdle<undefined>
in use case
AS-IS
TO-BE
How to correct
AS-IS
TO-BE
PR Checklist