-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): update wrap as builder pattern #280
feat(react): update wrap as builder pattern #280
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov Report
@@ Coverage Diff @@
## react/feat/wrap #280 +/- ##
=================================================
Coverage 100.00% 100.00%
=================================================
Files 24 24
Lines 752 839 +87
Branches 126 143 +17
=================================================
+ Hits 752 839 +87
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GooD!
@okinawaa Review this Pull Request please. I want to get approval from all maintainers because this new feature will be important change of @suspensive/react |
@okinawaa I merge this to react/feat/wrap first, because I think this branch's implementation is better than it. then review react/feat/wrap's Pull Request plesae. If it have problem, I will change it |
related with #269
Overview
I update wrap as builder pattern to remove wrap nesting.
AS-IS (wrap nesting with importing all public apis(ErrorBoundary, Suspense, etc.))
TO-BE (wrap builder with no import)
PR Checklist