Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function to automatically decompress GZIP resources #4

Merged
merged 5 commits into from
Aug 2, 2016

Conversation

federkasten
Copy link
Contributor

This PR adds a function to automatically decompress GZIP resources.
You can specify the decompression behavior using :pack key in cavia's profile.

Also, this PR contains a patch that fixes an integer overflow issue around handing content-length.

@totakke
Copy link
Owner

totakke commented Aug 2, 2016

Thank you for good PR. The unpacking feature is very convenient.

But :pack key name is misleading. Someone may understand it that downloaded resources will be packed.

I think that :unpack or :packed key name is better. Please fix the key name only.

@federkasten
Copy link
Contributor Author

Thank you for the review.

I have modified a key for automatic decompression, from :pack to :packed.

@totakke totakke merged commit dd71ca4 into totakke:master Aug 2, 2016
@totakke
Copy link
Owner

totakke commented Aug 2, 2016

Thank you. I've just merged this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants