Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

special chars are not escaped #48

Closed
oupala opened this issue Sep 14, 2017 · 4 comments
Closed

special chars are not escaped #48

oupala opened this issue Sep 14, 2017 · 4 comments

Comments

@oupala
Copy link

oupala commented Sep 14, 2017

When using special chars such as the french ç, the chat seems to be not escaped.

Hence, when listing all document containing the tag français, the page http://localhost:8080/tags/francais/ does not list the documents that contain the français tag but only the documents that contains the francais tag..

@gijswijs
Copy link
Collaborator

gijswijs commented Jun 2, 2020

PR is merged, new version published to NPM.

@gijswijs gijswijs closed this as completed Jun 2, 2020
@oupala
Copy link
Author

oupala commented Jun 2, 2020

This is a very very good news @gijswijs.

I tested the new version and it works well.

A few suggestions for the futur:

  • the changelog has not been updated
  • I had to add a new option (normalize: true) to my build file, and it was not obvious for me what was the default value of this option. I think it would be a good thing to indicate the default value of each option if not specified.

@gijswijs
Copy link
Collaborator

gijswijs commented Jun 3, 2020

Thank you for the suggestions @oupala. I'm still trying to get into a workflow here.

Next time I will update the changelog for both this version and the new one.

Just so that I'm sure I understand you:
You would like to see the default value of all the options specified in the readme?

@oupala
Copy link
Author

oupala commented Jun 3, 2020

You would like to see the default value of all the options specified in the readme?

Yes, exactly.

If the default values fits my need, I don't need to overwrite them. Otherwise, I have to had the options and their new value to the build file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants