Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bit more checking on the params #5

Closed
tttp opened this issue Oct 19, 2012 · 1 comment
Closed

Bit more checking on the params #5

tttp opened this issue Oct 19, 2012 · 1 comment

Comments

@tttp
Copy link
Contributor

tttp commented Oct 19, 2012

Hi,

So I'm monkey testing civix, love it so far.

I am putting params that don't have the expected syntax, eg:
civix generate:page api_settings civicrm/admin/setting
civix generate:page eu.tttp.settings civicrm/admin/setting

and it more or less happily generate some files, but that aren't the right format so when testing further down got plenty of errors (eg because class name contains a .)

I'm sure it will be obvious soon what I can put or or, but in the discovery phase for noobs, bit of a pita.

Would be great to add some extra sanity checking, eg if the name of the page can only be [a-z]- add that test to avoid generating garbage.

X+

@totten
Copy link
Owner

totten commented Oct 31, 2012

Patched in 041a7dd

@totten totten closed this as completed Oct 31, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants