Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add user/password ans api_key to Carol #529

Merged
merged 3 commits into from
Mar 31, 2021
Merged

add user/password ans api_key to Carol #529

merged 3 commits into from
Mar 31, 2021

Conversation

rafarui
Copy link
Collaborator

@rafarui rafarui commented Mar 26, 2021

Please provide details about this Pull Request (why the change is being made, what this commit will do):

Today we need to either pass the AUTH to Carol constructor or use env. variables. I added the username/password and api_key to the constructor to make the life of users easy.

Please provide links to relevant Trello cards, Slab topics or support ticket:

@rafarui rafarui requested a review from a team March 26, 2021 17:38
@rafarui rafarui self-assigned this Mar 26, 2021
@rafarui rafarui requested review from darolt and removed request for a team March 26, 2021 17:38
@rafarui rafarui enabled auto-merge (squash) March 31, 2021 10:57
@rafarui rafarui disabled auto-merge March 31, 2021 10:57
@rafarui rafarui merged commit 8a29c4a into master Mar 31, 2021
@rafarui rafarui deleted the user-pass-toekn branch March 31, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant