Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: returning dataframe when using bq and dataset if #565

Merged
merged 3 commits into from
Dec 14, 2021

Conversation

rafarui
Copy link
Collaborator

@rafarui rafarui commented Dec 12, 2021

Please provide details about this Pull Request (why the change is being made, what this commit will do):

Please provide links to relevant Trello cards, Slab topics or support ticket:

fixing #563 and
#564

for #564 you were using a sandbox, today carol does not provide an API to pycarol to solve the dataset ID, so I added a option to overwrite the default production dataset_id

@rafarui rafarui requested a review from darolt December 12, 2021 08:00
@rafarui rafarui changed the title fix returning dataframe when using bq and dataset if bug: returning dataframe when using bq and dataset if Dec 12, 2021
@rafarui rafarui merged commit 5d13a69 into master Dec 14, 2021
@rafarui rafarui deleted the bigquery-dataframe branch December 14, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant