feat: add labels to bigquery job #620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide details about this Pull Request (why the change is being made, what this commit will do):
The PR adds labels to the BigQuery.JobConfig in order to help us understand the job's performances better and enable new segmentation strategies for the Carol Apps.
Please provide links to relevant Trello cards, Slab topics or support tickets:
https://totvslabs.atlassian.net/browse/DASC-1208?atlOrigin=eyJpIjoiOWZhZTc4ZDViYmUxNDhlNmIyNWVkOGY4YWRmNTc0ZjciLCJwIjoiaiJ9
Attention Points
BQ.queryfunction has not changed in a production test. I was unable to verify that the labels were added to the BigQuery job because I don't have access to the tables. Maybe there is another way to check this in production, but I couldn't find it.