[feat][TRIP-10326] Add sentry captureMessage to Google calendar services #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haffla
requested changes
Oct 23, 2023
|
@haffla I thought about that, but adding an extra string gives us a nicer visualization in the sentry report when it arrives in the slack channel. The error object is also available in the Sentry report page. But if you don't like it I can also remove the extra string part |
|
The visualization was actually my concern. This will result in quite long strings and I am not sure what "....: ${error}" will return. I think Sentry displays errors in a good way. |
haffla
requested changes
Oct 24, 2023
| @@ -286,6 +289,8 @@ export default class GoogleCalendarService implements Calendar { | |||
| * 410 is when an event is already deleted on the Google cal before on cal.com | |||
| * 404 is when the event is on a different calendar | |||
| */ | |||
| Sentry.captureException(err); | |||
There was a problem hiding this comment.
I think here we actually don't want to always report the error. Only if the error code is not equal to 404 and not equal to 410. Only when this code returns a rejected promise, should we report the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context/Change
https://tourlane.atlassian.net/browse/TRIP-10326