Remove build dependency on autotools #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including libffi as a git submodule means that the "configure" script needs to be further generated at build time. Doing so depends on autotools, an unnecessary dependency. Instead this commit includes the files in libffi-3.4.2.tar.gz directly in the repository, which includes the "configure" script.
|
@yorickpeterse I've squashed the commits into something landable. The |
|
@ry Thanks! One final question: if we use those tarballs, do we need to run |
|
No need to run autogen, the libffi maintainers run that when they build the distributed tarball. |
|
@ry I pushed libffi-sys 1.3.0 which includes these changes. Thanks for the patch! |
ry
added a commit
to ry/deno
that referenced
this pull request
Oct 26, 2021
Fork is no longer necessary since tov/libffi-rs#33 landed.
ry
added a commit
to ry/deno
that referenced
this pull request
Oct 26, 2021
Fork is no longer necessary since tov/libffi-rs#33 landed.
ry
added a commit
to denoland/deno
that referenced
this pull request
Oct 26, 2021
Fork is no longer necessary since tov/libffi-rs#33 landed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the source code of libffi directly in the repository and includes the generated
libffi-sys-rs/libffi/configurescript.Fixes #32