-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove build dependency on autotools #33
Conversation
Including libffi as a git submodule means that the "configure" script needs to be further generated at build time. Doing so depends on autotools, an unnecessary dependency. Instead this commit includes the files in libffi-3.4.2.tar.gz directly in the repository, which includes the "configure" script.
@yorickpeterse I've squashed the commits into something landable. The |
@ry Thanks! One final question: if we use those tarballs, do we need to run |
No need to run autogen, the libffi maintainers run that when they build the distributed tarball. |
@ry I pushed libffi-sys 1.3.0 which includes these changes. Thanks for the patch! |
Fork is no longer necessary since tov/libffi-rs#33 landed.
Fork is no longer necessary since tov/libffi-rs#33 landed.
Fork is no longer necessary since tov/libffi-rs#33 landed.
This PR includes the source code of libffi directly in the repository and includes the generated
libffi-sys-rs/libffi/configure
script.Fixes #32