Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #204 to 0.1.x #213

Merged
merged 1 commit into from
Jan 22, 2022
Merged

Backport #204 to 0.1.x #213

merged 1 commit into from
Jan 22, 2022

Conversation

davidpdrsn
Copy link
Member

This backports the fix in #212 such that we can release 0.1.3 which should fix #212.

@davidpdrsn davidpdrsn mentioned this pull request Jan 22, 2022
Closed
Nehliin
Nehliin approved these changes Jan 22, 2022
View reviewed changes
Copy link
Collaborator

@Nehliin Nehliin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could also make sense to add a test + windows machine i ci if possible to ensure it doesn't regress and also doesn't happen on other platforms

@davidpdrsn
Copy link
Member Author

I think it could also make sense to add a test + windows machine i ci if possible to ensure it doesn't regress and also doesn't happen on other platforms

Yes thats a good idea! Can do that in a follow up

@davidpdrsn davidpdrsn merged commit 31c7a8e into 0.1.x Jan 22, 2022
@davidpdrsn davidpdrsn deleted the backport-directory-traversal-fix branch January 22, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nehliin Nehliin Nehliin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidpdrsn @Nehliin