spawn-ready: Avoid oneshot allocations #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies the `SpawnReady` service to track a `tokio::task::JoinHandle` instead of creating a `tokio::sync::oneshot` on each pending poll. This avoid unnecessary allocation. The `spawn_ready` test is also fixed to avoid using `thread::sleep`, instead using `tokio::time::pause`.
olix0r
force-pushed
the
ver/spawn-ready-no-oneshot
branch
from
6f48ab1
to
90d4cd1
Compare
LucioFranco
reviewed
Jan 19, 2021
LucioFranco
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the
SpawnReadyservice to track atokio::task::JoinHandleinstead of creating atokio::sync::oneshoton each pending poll. This avoid unnecessary allocation.
The
spawn_readytest is also fixed to avoid usingthread::sleep,instead using
tokio::time::pause.