tower: prepare to release v0.4.5 #558
Conversation
|
Mind if we also try to get #557 in? Should be merged shortly. |
|
Sure thing. I'll be going to bed in ~1 hour so feel free to take over this PR. |
tower/CHANGELOG.md
Outdated
|
|
||
| ### Fixed | ||
|
|
||
| - **util**: Make combinators implement `Debug` in more cases. ([#552]) |
There was a problem hiding this comment.
nit: can we clarify "in more cases"? specifically, I think this is that the Debug impl doesn't require the closure/function to be Debug...and in practice, i think these types will never implement Debug....
tower/CHANGELOG.md
Outdated
| - **util**: Add `option_layer` to convert an `Option<Layer>` into a `Layer`. ([#555]) | ||
| - **builder**: Add `ServiceBuilder::option_layer` to optionally add a layer. ([#555]) | ||
| - **steer**: `Steer` now implements `Clone | ||
| - **make**: Added `Shared` which lets you implement `MakeService` by cloning a |
There was a problem hiding this comment.
nit: the tense here is inconsistent with the other entries ("Added ..." rather than "Add ..."). We should probably try to keep that consistent across releases, but let's at least keep it consistent here?
(it's entirely possible that i'm the only person in the world who cares about this, sorry!)
There was a problem hiding this comment.
Its all about the little things 😊
|
@davidpdrsn if you don't mind rebasing onto master to pick up #557, I think we'll be good to go! |
davidpdrsn
force-pushed
the
david/0.4.5
branch
from
3aec71a
to
c7a5d96
Compare
No description provided.