Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor directory structure #274

Closed
5 of 7 tasks
fzliu opened this issue Nov 2, 2021 · 8 comments · Fixed by #382 or #383
Closed
5 of 7 tasks

Refactor directory structure #274

fzliu opened this issue Nov 2, 2021 · 8 comments · Fixed by #382 or #383
Assignees
Labels

Comments

@fzliu
Copy link
Member

fzliu commented Nov 2, 2021

Refactor Directory Structure

Title says it all.

Task List


  • move all operators and pipelines from /towhee/tests to /operators and /pipelines
  • remove emulated_pipeline from tests directory.
  • move /towhee/tests to /tests/unittests and update relevant paths in test files.
  • combine /towhee/cnn_trainer and /towhee/trainer, data.
  • combine array, and dataframe.
  • remove data_source.
  • remove utils folder (so it does not become an outpost for random functions) and move existing files within, if possible move hub_tools.py to separate hub folder and handler_mixin.py to engine
towhee [project]
  |- towhee [codebase]
  |- tests  # shares same directory tree as towhee [codebase]
  |- operators
  |- pipelines
  |- docs
  |- bootcamp
  |- setup.py
  |- README.md
  |- pylint.conf

towhee [codebase]
  |- engine
  |- models
    |- layers
    |- individual models
    |- utils
  |- trainer
    |- trainer.py  # abstract Trainer class
    |- train_args.py
    |- cnn_trainer.py
    |- transformer_trainer.py
    |- gan_trainer.py
  |- data
    |- dataset
      |- PytorchImageDataset.py
      |- PytorchVideoDataset.py
      |- TFImageDataset.py
    |- transforms
  |- cache
    |- hub
  |- common
    |- decorators
    |- mixins
  |- logger.py
  |- error.py
  |- type.py
@stale
Copy link

stale bot commented Dec 3, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Close the stale issues and pull requests after 7 days of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale label Dec 3, 2021
@binbinlv
Copy link
Contributor

binbinlv commented Dec 7, 2021

@fzliu  for tests contents, I think it could be specified as the following. "UnitTest" part is for UT, and I will add all the functional tests part into "FunctionTest". Is it OK?

Thanks.

towhee [project]
  |- towhee [codebase]
  |- tests  # shares same directory tree as towhee [codebase]
      |- UnitTest
      |- FunctionTest
  |- operators
  |- pipelines
  |- docs
  |- bootcamp
  |- setup.py
  |- README.md
  |- pylint.conf

@stale stale bot removed the stale label Dec 7, 2021
@fzliu
Copy link
Member Author

fzliu commented Dec 20, 2021

@binbinlv This looks fine; we'll put our individual UTs under towhee/tests/unittests then.

@binbinlv
Copy link
Contributor

@fzliu cool, thanks.

@junjiejiangjjj junjiejiangjjj linked a pull request Jan 4, 2022 that will close this issue
@junjiejiangjjj junjiejiangjjj linked a pull request Jan 4, 2022 that will close this issue
@junjiejiangjjj junjiejiangjjj reopened this Jan 5, 2022
@stale
Copy link

stale bot commented Feb 4, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Close the stale issues and pull requests after 7 days of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale label Feb 4, 2022
@stale stale bot closed this as completed Feb 11, 2022
@fzliu
Copy link
Member Author

fzliu commented Feb 11, 2022

/reopen

@sre-ci-robot
Copy link
Contributor

@fzliu: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sre-ci-robot sre-ci-robot reopened this Feb 11, 2022
@stale stale bot removed the stale label Feb 11, 2022
@stale
Copy link

stale bot commented Mar 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Close the stale issues and pull requests after 7 days of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale label Mar 13, 2022
@stale stale bot closed this as completed Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants