Remove publish job from the check workflow #361
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to be a job that existed before we began publishing new releases using PyPI's trusted publisher feature in release.yml.
From exploring the Actions/Deployments tab, I could not find an instance where this job was ran. Seeing the
check
workflow configuration, we ignore all tag push events because of thetags-ignore
usage. This would mean thatpublish
will always be skipped since we don't listen for tag pushes in thecheck
workflow. We also no longer have apypi_password
secret so even if it were to run it should fail.I also decided to just remove the
tags-ignore
as according to the docs (though the wording is a tad weird), tag push events won't trigger a workflow run if we specify onlybranch
.