Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove publish job from the check workflow #361

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

kemzeb
Copy link
Collaborator

@kemzeb kemzeb commented Apr 30, 2024

This appears to be a job that existed before we began publishing new releases using PyPI's trusted publisher feature in release.yml.

From exploring the Actions/Deployments tab, I could not find an instance where this job was ran. Seeing the check workflow configuration, we ignore all tag push events because of the tags-ignore usage. This would mean that publish will always be skipped since we don't listen for tag pushes in the check workflow. We also no longer have a pypi_password secret so even if it were to run it should fail.

I also decided to just remove the tags-ignore as according to the docs (though the wording is a tad weird), tag push events won't trigger a workflow run if we specify only branch.

@kemzeb kemzeb changed the title Remove "publish" job from the check workflow Remove publish job from the check workflow Apr 30, 2024
@kemzeb kemzeb merged commit 4c832b5 into tox-dev:main Apr 30, 2024
9 checks passed
@kemzeb kemzeb deleted the remove-publish-job branch April 30, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants