Plugin is broken with release of tox-3.8.0

[drdavella]

The following error occurs when running tox-conda with tox-3.8.0:

Traceback (most recent call last):
  File "/home/travis/miniconda/envs/test/bin/tox", line 10, in <module>
    sys.exit(cmdline())
  File "/home/travis/miniconda/envs/test/lib/python3.6/site-packages/tox/session/__init__.py", line 42, in cmdline
    main(args)
  File "/home/travis/miniconda/envs/test/lib/python3.6/site-packages/tox/session/__init__.py", line 63, in main
    retcode = session.runcommand()
  File "/home/travis/miniconda/envs/test/lib/python3.6/site-packages/tox/session/__init__.py", line 187, in runcommand
    return self.subcommand_test()
  File "/home/travis/miniconda/envs/test/lib/python3.6/site-packages/tox/session/__init__.py", line 215, in subcommand_test
    run_sequential(self.config, self.venv_dict)
  File "/home/travis/miniconda/envs/test/lib/python3.6/site-packages/tox/session/commands/run/sequential.py", line 9, in run_sequential
    if venv.setupenv():
  File "/home/travis/miniconda/envs/test/lib/python3.6/site-packages/tox/venv.py", line 582, in setupenv
    status = self.update(action=action)
  File "/home/travis/miniconda/envs/test/lib/python3.6/site-packages/tox/venv.py", line 240, in update
    self.hook.tox_testenv_create(action=action, venv=self)
  File "/home/travis/miniconda/envs/test/lib/python3.6/site-packages/pluggy/hooks.py", line 289, in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
  File "/home/travis/miniconda/envs/test/lib/python3.6/site-packages/pluggy/manager.py", line 68, in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
  File "/home/travis/miniconda/envs/test/lib/python3.6/site-packages/pluggy/manager.py", line 62, in <lambda>
    firstresult=hook.spec.opts.get("firstresult") if hook.spec else False,
  File "/home/travis/miniconda/envs/test/lib/python3.6/site-packages/pluggy/callers.py", line 208, in _multicall
    return outcome.get_result()
  File "/home/travis/miniconda/envs/test/lib/python3.6/site-packages/pluggy/callers.py", line 80, in get_result
    raise ex[1].with_traceback(ex[2])
  File "/home/travis/miniconda/envs/test/lib/python3.6/site-packages/pluggy/callers.py", line 187, in _multicall
    res = hook_impl.function(*args)
  File "/home/travis/miniconda/envs/test/lib/python3.6/site-packages/tox_conda/plugin.py", line 100, in tox_testenv_create
    venv.session.make_emptydir(venv.path)
AttributeError: 'VirtualEnv' object has no attribute 'session'

This seems like a backwards incompatible API change in tox which was not mentioned anywhere in the change log, so maybe this issue is really a bug there.

[gaborbernat]

Let's fix this by adhering to the new contract 👍

[gaborbernat]

@drdavella can you please cut a new release from master?

[drdavella]

@gaborbernat yes I can do that, although I should also make the tox developers an owner of the repo on pypi. Maybe you can email me to tell me the account name?

[gaborbernat]

hello gaborbernat is my handle 👌

[AnneTheAgile]

This ticket should be closed, fixed, per
https://github.com/tox-dev/tox-conda/releases/tag/0.2.0
#16

GitHub

tox-dev/tox-conda

Make tox cooperate with conda envs. Contribute to tox-dev/tox-conda development by creating an account on GitHub.