Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop use of VIRTUAL_ENV=${Python_ROOT_DIR} workaround #57

Merged
merged 2 commits into from
May 24, 2024

Conversation

zanieb
Copy link
Contributor

@zanieb zanieb commented May 24, 2024

Hi!

In the latest uv release, we no longer support this for using the system Python. You can see some more context at astral-sh/uv#3765 and inventree/InvenTree#7317.

@zanieb zanieb requested a review from gaborbernat as a code owner May 24, 2024 15:06
.github/workflows/check.yml Outdated Show resolved Hide resolved
gaborbernat
gaborbernat previously approved these changes May 24, 2024
@gaborbernat gaborbernat enabled auto-merge (squash) May 24, 2024 15:23
@zanieb
Copy link
Contributor Author

zanieb commented May 24, 2024

Ah interesting, this fails with

error: the argument '--python ' cannot be used with '--system'

I presume that means you do not need the global system flag.

auto-merge was automatically disabled May 24, 2024 15:27

Head branch was pushed to by a user without write access

Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit f1c5688 into tox-dev:main May 24, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants