fix windows selects incorrect spec #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we should make sure that the tests pass on master since they haven't been running in a while heh |
damn 🤔 |
|
Comment from the peanut gallery: I have been staring at this diff for 10 minutes and still don't understand what's the difference 🤦♂️ |
|
the py variable is used in the second part of the function, by using it as a loop variable we override it , breaking the logic |
|
😮 Thanks for clarifying! |
|
Are you going to resolve this? |
? this patch is merged and released |
what the solution? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤦♂ yeah, an overriding variable, quite sneaky