Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix windows selects incorrect spec #1317

Merged
merged 1 commit into from May 23, 2019
Merged

fix windows selects incorrect spec #1317

merged 1 commit into from May 23, 2019

Conversation

@gaborbernat
Copy link
Member

@gaborbernat gaborbernat commented May 23, 2019

馃う鈥嶁檪 yeah, an overriding variable, quite sneaky

Copy link
Member

@asottile asottile left a comment

lol 馃う鈥嶁檪锔

@gaborbernat gaborbernat merged commit 5813770 into tox-dev:master May 23, 2019
1 check was pending
@gaborbernat gaborbernat deleted the py branch May 23, 2019
@asottile
Copy link
Member

@asottile asottile commented May 23, 2019

we should make sure that the tests pass on master since they haven't been running in a while heh

@gaborbernat
Copy link
Member Author

@gaborbernat gaborbernat commented May 23, 2019

[5156] D:\a\1\s\.tox$ 'C:\hostedtoolcache\windows\Python\3.7.2\x64\python.exe' -m virtualenv --no-download --python 'C:\Python27amd64\python.exe' 

damn 馃

@astrojuanlu
Copy link

@astrojuanlu astrojuanlu commented Jun 2, 2019

Comment from the peanut gallery: I have been staring at this diff for 10 minutes and still don't understand what's the difference 馃う鈥嶁檪锔

@gaborbernat
Copy link
Member Author

@gaborbernat gaborbernat commented Jun 2, 2019

the py variable is used in the second part of the function, by using it as a loop variable we override it , breaking the logic 鈽癸笍 on python 2 the loop variables leak.. 馃憣

@astrojuanlu
Copy link

@astrojuanlu astrojuanlu commented Jun 2, 2019

馃槷 Thanks for clarifying!

@itzdan
Copy link

@itzdan itzdan commented Jun 5, 2020

Are you going to resolve this?

@asottile
Copy link
Member

@asottile asottile commented Jun 5, 2020

Are you going to resolve this?

? this patch is merged and released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants