Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix windows selects incorrect spec #1317

Merged
merged 1 commit into from
May 23, 2019
Merged

Conversation

gaborbernat
Copy link
Member

🤦‍♂ yeah, an overriding variable, quite sneaky

Copy link
Contributor

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol 🤦‍♂️

@gaborbernat gaborbernat merged commit 5813770 into tox-dev:master May 23, 2019
@gaborbernat gaborbernat deleted the py branch May 23, 2019 17:21
@asottile
Copy link
Contributor

we should make sure that the tests pass on master since they haven't been running in a while heh

@gaborbernat
Copy link
Member Author

[5156] D:\a\1\s\.tox$ 'C:\hostedtoolcache\windows\Python\3.7.2\x64\python.exe' -m virtualenv --no-download --python 'C:\Python27amd64\python.exe' 

damn 🤔

@astrojuanlu
Copy link

Comment from the peanut gallery: I have been staring at this diff for 10 minutes and still don't understand what's the difference 🤦‍♂️

@gaborbernat
Copy link
Member Author

the py variable is used in the second part of the function, by using it as a loop variable we override it , breaking the logic ☹️ on python 2 the loop variables leak.. 👌

@astrojuanlu
Copy link

😮 Thanks for clarifying!

@itzdan
Copy link

itzdan commented Jun 5, 2020

Are you going to resolve this?

@asottile
Copy link
Contributor

asottile commented Jun 5, 2020

Are you going to resolve this?

? this patch is merged and released

@ihabpalamino
Copy link

this patch is merged and released

what the solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants