Add quote marks so readers are not tripped up by spaces in their path… #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
asottile,
gaborbernat and
obestwalter
as code owners
|
I agree the change here should be internal not documentation side. For now will fly with the documentation change though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox ran beautifully on my laptop but when I moved to my work PC with a different version of python to test my project without installing five versions of python on my laptop it just wouldn't work. Careful inspection of the error message was not really helpful other than tox being unable to find my tests but I've had the spaces in path names issue with other software so I tried adding quotes in my tox.ini and it worked. I have made a trivial update to the documentation adding quotes on the page I was following. There may be more places where adding quotes would be advisable. Alternatively, tox should quote file paths internally making the documentation changes irrelevant.