Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tox.ini in sdist to fix tests #2939

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Mar 13, 2023

Include the tox.ini file in sdist, in order to fix a few test failures due to an additional error message printed by tox, i.e.:

FAILED tests/config/cli/test_parse.py::test_verbosity_guess_miss_match - AssertionError: assert 'ROOT: No tox.ini or setup.cfg or pyproject.toml found, assuming empty tox.ini at /tmp/portage/dev-python/t...
FAILED tests/config/loader/test_loader.py::test_override_incorrect[-x] - AssertionError: assert not 'ROOT: No tox.ini or setup.cfg or pyproject.toml found, assuming empty tox.ini at /tmp/portage/dev-pyth...
FAILED tests/config/loader/test_loader.py::test_override_incorrect[--override] - AssertionError: assert not 'ROOT: No tox.ini or setup.cfg or pyproject.toml found, assuming empty tox.ini at /tmp/portage/dev-pyth...

Thanks for contribution

Please, make sure you address all the checklists (for details on how see
development documentation)!

  • ran the linter to address style issues (tox -e fix)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix (existing tests suffice)
  • added news fragment in docs/changelog folder
  • updated/extended the documentation (n/a)

@gaborbernat
Copy link
Member

No misc please either bugfix or enhancement.

Include the `tox.ini` file in sdist, in order to fix a few test failures
due to an additional error message printed by tox, i.e.:

    FAILED tests/config/cli/test_parse.py::test_verbosity_guess_miss_match - AssertionError: assert 'ROOT: No tox.ini or setup.cfg or pyproject.toml found, assuming empty tox.ini at /tmp/portage/dev-python/t...
    FAILED tests/config/loader/test_loader.py::test_override_incorrect[-x] - AssertionError: assert not 'ROOT: No tox.ini or setup.cfg or pyproject.toml found, assuming empty tox.ini at /tmp/portage/dev-pyth...
    FAILED tests/config/loader/test_loader.py::test_override_incorrect[--override] - AssertionError: assert not 'ROOT: No tox.ini or setup.cfg or pyproject.toml found, assuming empty tox.ini at /tmp/portage/dev-pyth...
@mgorny
Copy link
Contributor Author

mgorny commented Mar 13, 2023

No misc please either bugfix or enhancement.

Ok, made it a bugfix.

@jugmac00 jugmac00 merged commit 78d1f64 into tox-dev:main Mar 13, 2023
@mgorny
Copy link
Contributor Author

mgorny commented Mar 13, 2023

Thank you!

@mgorny mgorny deleted the sdist-test-fix branch March 13, 2023 14:56
descope bot referenced this pull request in descope/django-descope Apr 9, 2023
This PR contains the following updates:

| Package | Type | Update | Change | Pending |
|---|---|---|---|---|
| [tox](https://togithub.com/tox-dev/tox)
([changelog](https://tox.wiki/en/latest/changelog.html)) | dev | patch |
`4.4.7` -> `4.4.8` | `4.4.11` (+2) |

---

### Release Notes

<details>
<summary>tox-dev/tox</summary>

### [`v4.4.8`](https://togithub.com/tox-dev/tox/releases/tag/4.4.8)

[Compare Source](https://togithub.com/tox-dev/tox/compare/4.4.7...4.4.8)

#### What's Changed

- Include `tox.ini` in sdist to fix tests by
[@&#8203;mgorny](https://togithub.com/mgorny) in
[https://github.com/tox-dev/tox/pull/2939](https://togithub.com/tox-dev/tox/pull/2939)
- Bump pypa/gh-action-pypi-publish from 1.6.4 to 1.7.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/tox-dev/tox/pull/2940](https://togithub.com/tox-dev/tox/pull/2940)
- docs: remove (dynamic) years from copyright by
[@&#8203;paravoid](https://togithub.com/paravoid) in
[https://github.com/tox-dev/tox/pull/2941](https://togithub.com/tox-dev/tox/pull/2941)
- Bump pypa/gh-action-pypi-publish from 1.7.1 to 1.8.1 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/tox-dev/tox/pull/2950](https://togithub.com/tox-dev/tox/pull/2950)
- Update documentation regarding `homedir` variable (upgrade to tox 4)
by [@&#8203;aelray](https://togithub.com/aelray) in
[https://github.com/tox-dev/tox/pull/2955](https://togithub.com/tox-dev/tox/pull/2955)
- Bump pypa/gh-action-pypi-publish from 1.8.1 to 1.8.3 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/tox-dev/tox/pull/2956](https://togithub.com/tox-dev/tox/pull/2956)
- Bump deps and tools by
[@&#8203;gaborbernat](https://togithub.com/gaborbernat) in
[https://github.com/tox-dev/tox/pull/2954](https://togithub.com/tox-dev/tox/pull/2954)
- docs: s/master/main/g in contributing docs by
[@&#8203;sk1p](https://togithub.com/sk1p) in
[https://github.com/tox-dev/tox/pull/2960](https://togithub.com/tox-dev/tox/pull/2960)
- Fix for requirements.txt using both --index-url and --find-links by
[@&#8203;sk1p](https://togithub.com/sk1p) in
[https://github.com/tox-dev/tox/pull/2959](https://togithub.com/tox-dev/tox/pull/2959)

#### New Contributors

- [@&#8203;aelray](https://togithub.com/aelray) made their first
contribution in
[https://github.com/tox-dev/tox/pull/2955](https://togithub.com/tox-dev/tox/pull/2955)
- [@&#8203;sk1p](https://togithub.com/sk1p) made their first
contribution in
[https://github.com/tox-dev/tox/pull/2960](https://togithub.com/tox-dev/tox/pull/2960)

**Full Changelog**: tox-dev/tox@4.4.7...4.4.8

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMDEuMCIsInVwZGF0ZWRJblZlciI6IjM0LjEwMS4wIn0=-->

Co-authored-by: descope[bot] <descope[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants