-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also search paired devices to get device by name #88
Conversation
Thank you for creating the PR I think it would be better to search both lists, first paired, then recent devices (maybe easiest is to concat arrays to not do it separately). |
@toy Please review the new changes. |
Nice I think it will be better to still show a separate error if there are no paired or recent devices, it will fail anyway, but error about empty list is more precise than one about not being able to find a device by name. Also please run |
@toy Done. |
I think it is still better to print error and exit if |
IOBluetoothDevice.recentDevices return empty list in macOS Monterey and later, also search paired devices to make --info "BY NAME" --connect "BY NAME" --disconnect "BY NAME" ... work again. Fix toy#62
Wanted to merge, but realised that you didn't add an entry to CHANGELOG.md, please write something following examples and please link there both this PR and the issue #62 |
@azuwis Thank you |
IOBluetoothDevice.recentDevices return empty list in macOS Monterey and
later, also search paired devices to make
--info "BY NAME"
--connect "BY NAME"
--disconnect "BY NAME"
...
work again.
Fix #62