Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collaboration with FastImage #17

Open
sandstrom opened this issue Apr 20, 2022 · 2 comments
Open

Collaboration with FastImage #17

sandstrom opened this issue Apr 20, 2022 · 2 comments

Comments

@sandstrom
Copy link

I was looking for a library to grab width/height out of an image, and found this one plus another (https://github.com/sdsykes/fastimage/).

Both look great! 🏅 There is some overlap in the supported image formats.

Here are the ones FastImage support:
https://github.com/sdsykes/fastimage/blob/master/lib/fastimage.rb#L93

Would there be any benefit in collaborating across these two projects?

Obviously fine to keep the two running side by side too.

It could also be a chance to flesh out the code base slightly, e.g. break out each file format into a separate ruby file and and break out utils methods into dedicated files.

cc @SamSaffron

This was referenced Apr 24, 2022
@toy
Copy link
Owner

toy commented Apr 24, 2022

Both projects can definitely improve: supported formats, optimisations.

Already did performance comparison after seeing fastimage/#benchmark and created issues (#18, #19).

@sandstrom
Copy link
Author

Another idea I'm throwing out here:

Maybe image_size gem/library could be focused on determining the size and image type, and fast_image could use image_size internally, but also add code for remote fetching?

That way, you could share code base for detection and metadata, but this gem wouldn't have to build out HTTP remote logic to "compete" with fast_image, and fast_image wouldn't have to duplicate the detection already present in this library.

As long as image_size provide (and I think it already does) an API for doing "chunked detection" (gradually feeding more image data until all metadata required for detection has been fed).

Just an idea though, not sure it's a good one.


Either way, this is a great gem! 💎

And me personally, we have no need for remote image detection, so would prefer this gem over fast_image anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants