Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return napi_generic_failure instead of throwing if runtime has no BigInt #76

Merged
merged 1 commit into from
Jul 1, 2023
Merged

return napi_generic_failure instead of throwing if runtime has no BigInt #76

merged 1 commit into from
Jul 1, 2023

Conversation

toyobayashi
Copy link
Owner

  • shouldn't throw if no $PREAMBLE!()
  • return napi_generic_failure instead of throwing if runtime has no BigInt
  • remove NotSupportBigIntError from @emnapi/runtime package

@toyobayashi toyobayashi merged commit 46b8690 into main Jul 1, 2023
@toyobayashi toyobayashi deleted the env-check-status branch July 1, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@toyobayashi