[WR-317] access policy plugin data #267
Conversation
identityClient/api.go
Outdated
| @@ -1025,6 +1025,9 @@ type AccessPolicy struct { | |||
| ApprovalRoles []Role `json:"approval_roles"` | |||
| RequiredApprovals int `json:"required_approvals"` | |||
| MaximumAccessDurationSeconds int `json:"max_access_duration_seconds"` | |||
| PluginType string `json:"plugin_type"` | |||
| PluginID string `json:"plugin_id"` | |||
| PluginSource string `json:"plugin_source"` | |||
There was a problem hiding this comment.
nit: now that I think about it more, PluginApprovalSource seems more intention revealing to me (and less confusing without comments to help distinguish between Type/Source)
There was a problem hiding this comment.
PluginProcessLocation it is both approval and creation of requests. So maybe more broad than approval source. I am ending up with 5 word names. PluginFlowManagementDataReferenceLocation 🤣
There was a problem hiding this comment.
PluginFlowManagementDataReferenceLocation🤣
😄
I am fine with anything at this point, I did comment the attributes in identity service api just not here.
Only downside to PluginApprovalSource is it doesn't tell the entire story (creation), but at the same time its probably enough info to know what it is for.
are either of these any better or maybe more confusing?
PluginMPCFlowSource, PluginMPCProcessingSource
There was a problem hiding this comment.
both PluginMPCFlowSource, PluginMPCProcessingSource introduce new concepts / names (Flow and Processing), so at least to me are more confusing then Approval. For TozID mpc requests, the approval source is a role, I'd argue for Jira the approval source is a board.
There was a problem hiding this comment.
after more thunking....PluginMPCFlowSource is a better name, and any confusion can be mitigated with a helpful comment
house9
force-pushed
the
WR-317-pam-settings-plugin
branch
from
b400721
to
9d2b531
Compare
https://toznysecurity.atlassian.net/browse/WR-317
see: https://github.com/tozny/identity-management-service/pull/323