-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SDK Registration Routine #18
Conversation
Add support for registration tokens to the SDK and update integration tests: - Registration via a token is explicitly tested - Both the test client and sharing client are dynamically registered
Permit new clients to register by passing an account token to the CLI Fixes E3DB-665
dieErr(err) | ||
} | ||
|
||
publicKey := e3db.ClientKey{Curve25519: base64.RawURLEncoding.EncodeToString(pub[:])} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we provide some kind of helper to generate the keys? It feels a bit like an interface fail that the caller of RegisterClient
needs to import NaCL to do the key generation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably applies to all the SDKs?
crypto.go
Outdated
|
||
func generateKeyPair() (publicKey, privateKey, error) { | ||
func generateKeyPair() (PublicKey, PrivateKey, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I see this, perhaps this should just be exported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Can do :-)
Add support for registration tokens to the SDK and update integration tests: