Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK Registration Routine #18

Merged
merged 5 commits into from
Aug 25, 2017
Merged

Update SDK Registration Routine #18

merged 5 commits into from
Aug 25, 2017

Conversation

ericmann
Copy link
Contributor

Add support for registration tokens to the SDK and update integration tests:

  • Registration via a token is explicitly tested
  • Both the test client and sharing client are dynamically registered

Add support for registration tokens to the SDK and update integration tests:
- Registration via a token is explicitly tested
- Both the test client and sharing client are dynamically registered
Permit new clients to register by passing an account token to the CLI

Fixes E3DB-665
@tozny tozny deleted a comment from coveralls Aug 22, 2017
@tozny tozny deleted a comment from coveralls Aug 22, 2017
@tozny tozny deleted a comment from coveralls Aug 22, 2017
dieErr(err)
}

publicKey := e3db.ClientKey{Curve25519: base64.RawURLEncoding.EncodeToString(pub[:])}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we provide some kind of helper to generate the keys? It feels a bit like an interface fail that the caller of RegisterClient needs to import NaCL to do the key generation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably applies to all the SDKs?

crypto.go Outdated

func generateKeyPair() (publicKey, privateKey, error) {
func generateKeyPair() (PublicKey, PrivateKey, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I see this, perhaps this should just be exported?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Can do :-)

@coveralls
Copy link

coveralls commented Aug 24, 2017

Coverage Status

Coverage decreased (-6.6%) to 50.563% when pulling f165a53 on feature/e3db-660 into 385794c on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-6.6%) to 50.563% when pulling f165a53 on feature/e3db-660 into 385794c on master.

@coveralls
Copy link

coveralls commented Aug 24, 2017

Coverage Status

Coverage decreased (-3.2%) to 53.942% when pulling 0d4e34c on feature/e3db-660 into 385794c on master.

@coveralls
Copy link

coveralls commented Aug 24, 2017

Coverage Status

Coverage increased (+7.2%) to 64.33% when pulling 722cad2 on feature/e3db-660 into 385794c on master.

@ericmann ericmann merged commit 15e72ad into master Aug 25, 2017
@ericmann ericmann deleted the feature/e3db-660 branch August 25, 2017 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants